lkml.org 
[lkml]   [2019]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 1/3] backlight: lm3630a: return 0 on success in update_status functions
From
Date
On 24/04/2019 10:25, Brian Masney wrote:
> lm3630a_bank_a_update_status() and lm3630a_bank_b_update_status()
> both return the brightness value if the brightness was successfully
> updated. Writing to these attributes via sysfs would cause a 'Bad
> address' error to be returned. These functions should return 0 on
> success, so let's change it to correct that error.
>
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> Fixes: 28e64a68a2ef ("backlight: lm3630: apply chip revision")
> Acked-by: Pavel Machek <pavel@ucw.cz>

Hi Brian, sorry for the delay. For some reason your mails are being
dumped before they reach me so I only discovered these patches when I
paid proper attention to the replies and fetched them from patchwork.

Hi Lee, is the same thing happening for you? ;-)

Acked-by: Daniel Thompson <daniel.thompson@linaro.org>


> ---
> No changes since v2 when this patch was originally introduced.
>
> drivers/video/backlight/lm3630a_bl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
> index 2030a6b77a09..ef2553f452ca 100644
> --- a/drivers/video/backlight/lm3630a_bl.c
> +++ b/drivers/video/backlight/lm3630a_bl.c
> @@ -201,7 +201,7 @@ static int lm3630a_bank_a_update_status(struct backlight_device *bl)
> LM3630A_LEDA_ENABLE, LM3630A_LEDA_ENABLE);
> if (ret < 0)
> goto out_i2c_err;
> - return bl->props.brightness;
> + return 0;
>
> out_i2c_err:
> dev_err(pchip->dev, "i2c failed to access\n");
> @@ -278,7 +278,7 @@ static int lm3630a_bank_b_update_status(struct backlight_device *bl)
> LM3630A_LEDB_ENABLE, LM3630A_LEDB_ENABLE);
> if (ret < 0)
> goto out_i2c_err;
> - return bl->props.brightness;
> + return 0;
>
> out_i2c_err:
> dev_err(pchip->dev, "i2c failed to access REG_CTRL\n");
>

\
 
 \ /
  Last update: 2019-05-02 12:08    [W:0.126 / U:2.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site