Messages in this thread Patch in this message | | | From | Laurentiu Tudor <> | Subject | RE: [PATCH v2 9/9] dpaa_eth: fix SG frame cleanup | Date | Thu, 2 May 2019 09:05:41 +0000 |
| |
Hi Joakim,
> -----Original Message----- > From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > Sent: Saturday, April 27, 2019 8:11 PM > > On Sat, 2019-04-27 at 10:10 +0300, laurentiu.tudor@nxp.com wrote: > > From: Laurentiu Tudor <laurentiu.tudor@nxp.com> > > > > Fix issue with the entry indexing in the sg frame cleanup code being > > off-by-1. This problem showed up when doing some basic iperf tests and > > manifested in traffic coming to a halt. > > > > Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com> > > Acked-by: Madalin Bucur <madalin.bucur@nxp.com> > > Wasn't this a stable candidate too?
Yes, it is. I forgot to add the cc:stable tag, sorry about that.
--- Best Regards, Laurentiu > > --- > > drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > > index daede7272768..40420edc9ce6 100644 > > --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > > +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > > @@ -1663,7 +1663,7 @@ static struct sk_buff *dpaa_cleanup_tx_fd(const > struct dpaa_priv *priv, > > qm_sg_entry_get_len(&sgt[0]), dma_dir); > > > > /* remaining pages were mapped with skb_frag_dma_map() > */ > > - for (i = 1; i < nr_frags; i++) { > > + for (i = 1; i <= nr_frags; i++) { > > WARN_ON(qm_sg_entry_is_ext(&sgt[i])); > > > > dma_unmap_page(dev, qm_sg_addr(&sgt[i]), > > -- > > 2.17.1 > >
| |