Messages in this thread | | | From | Masahiro Yamada <> | Date | Sat, 18 May 2019 14:29:30 +0900 | Subject | Re: [RFC 1/3] kbuild: add support for ensuring headers are self-contained |
| |
On Fri, May 17, 2019 at 5:35 PM Chris Wilson <chris@chris-wilson.co.uk> wrote: > > Quoting Jani Nikula (2019-05-16 20:48:16) > > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > > index 8a1f64f17740..c2839de06485 100644 > > --- a/scripts/Makefile.lib > > +++ b/scripts/Makefile.lib > > @@ -66,6 +66,9 @@ extra-y += $(patsubst %.dtb,%.dt.yaml, $(dtb-y)) > > extra-$(CONFIG_OF_ALL_DTBS) += $(patsubst %.dtb,%.dt.yaml, $(dtb-)) > > endif > > > > +# Test self-contained headers > > +extra-$(CONFIG_HEADER_TEST) += $(patsubst %.h,%.header_test.o,$(header-test-y)) > > This didn't get pulled into clean-files. > > clean-files-$(CONFIG_HEADER_TEST) += $(patsubst %.h,%.header_test.c,$(header-test-y)) > ? > > Not enough. Nor is clean-files-y +=...
The correct syntax is 'clean-files +=' instead of 'clean-files-y +='
If Kbuild supports this in the core Makefiles, we can add "-o -name '*.header_test.c'" to the top Makefile.
> And it should also be put into the global gitignore I think.
Documentation/dontdiff too.
> -Chris
-- Best Regards Masahiro Yamada
| |