lkml.org 
[lkml]   [2019]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] kernel: fix typos and some coding style in comments
On Sat, May 18, 2019 at 06:16:28PM +0800, Weitao Hou wrote:
> fix lenght to length

Can you please fix all the instances of this in the tree?

$ git grep lenght | grep -v spelling.txt
Documentation/devicetree/bindings/usb/s3c2410-usb.txt: - reg: address and lenght of the controller memory mapped region
drivers/net/wireless/mediatek/mt76/mt76x02_usb_core.c: * length, need to update lenght of it and the last packet.
kernel/sysctl.c: * passed the max lenght will be ignored. Multiple writes will append
sound/soc/qcom/qdsp6/q6asm.c: * @len: lenght in bytes

> Signed-off-by: Weitao Hou <houweitaoo@gmail.com>
> ---
> kernel/sysctl.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index 943c89178e3d..0736a1d580df 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -187,17 +187,17 @@ extern int no_unaligned_warning;
> * enum sysctl_writes_mode - supported sysctl write modes
> *
> * @SYSCTL_WRITES_LEGACY: each write syscall must fully contain the sysctl value
> - * to be written, and multiple writes on the same sysctl file descriptor
> - * will rewrite the sysctl value, regardless of file position. No warning
> - * is issued when the initial position is not 0.
> + * to be written, and multiple writes on the same sysctl file descriptor
> + * will rewrite the sysctl value, regardless of file position. No warning
> + * is issued when the initial position is not 0.
> * @SYSCTL_WRITES_WARN: same as above but warn when the initial file position is
> - * not 0.
> + * not 0.
> * @SYSCTL_WRITES_STRICT: writes to numeric sysctl entries must always be at
> - * file position 0 and the value must be fully contained in the buffer
> - * sent to the write syscall. If dealing with strings respect the file
> - * position, but restrict this to the max length of the buffer, anything
> - * passed the max lenght will be ignored. Multiple writes will append
> - * to the buffer.
> + * file position 0 and the value must be fully contained in the buffer
> + * sent to the write syscall. If dealing with strings respect the file
> + * position, but restrict this to the max length of the buffer, anything
> + * passed the max length will be ignored. Multiple writes will append
> + * to the buffer.

Also, why the reflow? It looks like these should stay indented...

> *
> * These write modes control how current file position affects the behavior of
> * updating sysctl values through the proc interface on each write.
> --
> 2.18.0
>

Besides that, thanks for noticing and sending a patch!

--
Kees Cook

\
 
 \ /
  Last update: 2019-05-19 03:56    [W:0.034 / U:1.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site