Messages in this thread Patch in this message | | | Subject | Re: [PATCH 4/5] staging: kpc2000: kpc_i2c: use %s with __func__ identifier in log messages | From | Joe Perches <> | Date | Fri, 17 May 2019 19:58:19 -0700 |
| |
On Sat, 2019-05-18 at 02:29 +0000, Geordan Neukum wrote: > Throughout i2c_driver.c, there are instances where the log strings > contain the function's name hardcoded into the string. Instead, use the > printk conversion specifier '%s' with the __func__ preprocessor > identifier to more maintainably print the function's name.
Might as well remove all of these and use the builtin ftrace function tracing mechanism instead.
> diff --git a/drivers/staging/kpc2000/kpc_i2c/i2c_driver.c b/drivers/staging/kpc2000/kpc_i2c/i2c_driver.c [] > @@ -142,7 +142,7 @@ static int i801_check_pre(struct i2c_device *priv) > { > int status; > > - dev_dbg(&priv->adapter.dev, "i801_check_pre\n"); > + dev_dbg(&priv->adapter.dev, "%s\n", __func__);
etc...
| |