[lkml]   [2019]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 0/4] uapi, vfs: Change the mount API UAPI [ver #2]
On May 17, 2019 9:13:26 AM GMT+02:00, David Howells <> wrote:
>Christian Brauner <> wrote:
>> If you still prefer to have cloexec flags
>> for the 4 new syscalls then yes,
>> if they could at least all have the same name
>> (FSMOUNT_CLOEXEC?) that would be good.
>They don't all have the same value (see OPEN_TREE_CLOEXEC).
>Note that I also don't want to blindly #define them to O_CLOEXEC
>because it's
>not necessarily the same value on all arches. Currently it can be
>010000000 or 0x400000 for instance, which means that if it's sharing a
>with other flags, at least three bits have to be reserved for it or we
>have to
>have arch-dependent bit juggling.

Ugh. Right, I forgot about that entirely.


>One thing I like about your approach of just making them O_CLOEXEC by
>and removing the constants is that it avoids this mess entirely.

 \ /
  Last update: 2019-05-17 09:27    [W:0.164 / U:0.004 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site