Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 17 May 2019 18:44:13 +0200 | Subject | Re: ext3/ext4 filesystem corruption under post 5.1.0 kernels |
| |
Hi Ted,
On Wed, May 15, 2019 at 6:57 AM Theodore Ts'o <tytso@mit.edu> wrote: > Ah, I think I see the problem. Sorry, this one was my fault. Does > this fix things for you?
Thanks! Sorry for missing this patch in the thread before.
> From 0c72924ef346d54e8627440e6d71257aa5b56105 Mon Sep 17 00:00:00 2001 > From: Theodore Ts'o <tytso@mit.edu> > Date: Wed, 15 May 2019 00:51:19 -0400 > Subject: [PATCH] ext4: fix block validity checks for journal inodes using indirect blocks > > Commit 345c0dbf3a30 ("ext4: protect journal inode's blocks using > block_validity") failed to add an exception for the journal inode in > ext4_check_blockref(), which is the function used by ext4_get_branch() > for indirect blocks. This caused attempts to read from the ext3-style > journals to fail with: > > [ 848.968550] EXT4-fs error (device sdb7): ext4_get_branch:171: inode #8: block 30343695: comm jbd2/sdb7-8: invalid block > > Fix this by adding the missing exception check. > > Fixes: 345c0dbf3a30 ("ext4: protect journal inode's blocks using block_validity") > Reported-by: Arthur Marsh <arthur.marsh@internode.on.net> > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Intermittent issue no more seen in 10 test boots, so Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |