lkml.org 
[lkml]   [2019]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] rcu: Remove unused variable
On Fri, May 17, 2019 at 11:51:11AM +0100, Lee Jones wrote:
> On Fri, 17 May 2019, Philippe Mazenauer wrote:
>
> > Variable 'rdp' is set but not used in synchronize_rcu_expidited(). The
> > macro per_cpu_ptr() used to set the value of 'rdp' has no side effect.
> >
> > ../kernel/rcu/tree_exp.h:768:19: warning: variable ‘rdp’ set but not used [-Wunused-but-set-variable]
> > struct rcu_data *rdp;
> > ^~~
> >
> > Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>
> > ---
> > kernel/rcu/tree_exp.h | 2 --
> > 1 file changed, 2 deletions(-)
>
> Looks reasonable:
>
> Acked-by: Lee Jones <lee.jones@linaro.org>

Good eyes!

However, Jiang Biao beat you to it. Please see commmit a18e1552af94
("rcu: Remove unused rdp local from synchronize_rcu_expedited()") in -rcu:
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git branch
"dev".

Thanx, Paul

\
 
 \ /
  Last update: 2019-05-17 13:59    [W:0.032 / U:19.088 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site