lkml.org 
[lkml]   [2019]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] USB: serial: mos7840: Prefer 'unsigned int' to bare use of 'unsigned'
On Thu, May 16, 2019 at 06:37:59PM +0530, parna.naveenkumar@gmail.com wrote:
> From: Naveen Kumar Parna <parna.naveenkumar@gmail.com>
>
> This fixes checkpatch.pl warning "WARNING: Prefer 'unsigned int' to
> bare use of 'unsigned'".

Please don't run checkpatch.pl on code that already in the kernel
(possibly with the exception of staging). Use it on your own patches
before you submit them if you want, and even then don't blindly follow
what checkpatch says.

Minor coding style issues are better left alone to avoid adding noise
and making code forensic and backports harder.

And in this case, there's not even anything wrong with the current code.

Johan

\
 
 \ /
  Last update: 2019-05-17 09:43    [W:0.059 / U:23.924 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site