lkml.org 
[lkml]   [2019]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RESEND PATCH] gnss: get serial speed from subdrivers
Date
On Wed 08 May 2019 at 17:53, Corentin Labbe <clabbe.montjoie@gmail.com> wrote:
>> -/*
>> - * FIXME: need to provide subdriver defaults or separate dt parsing from
>> - * allocation.
>> - */
>> static int gnss_serial_parse_dt(struct serdev_device *serdev)
>> {
>> struct gnss_serial *gserial = serdev_device_get_drvdata(serdev);
>> struct device_node *node = serdev->dev.of_node;
>> - u32 speed = 4800;
>> + uint speed;
>>
>> - of_property_read_u32(node, "current-speed", &speed);
>> + of_property_read_u32(node, "default-speed", &speed);
>
> Hello
>
> of_property_read_u32 use u32, so no reason to use uint instead.
>
> Regards

Hello Corentin,

Thank you for your review. A v2 has been sent:
https://lore.kernel.org/lkml/1558024626-19395-1-git-send-email-lollivier@baylibre.com/

Cheers,
Loys

\
 
 \ /
  Last update: 2019-05-16 18:44    [W:0.029 / U:28.396 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site