lkml.org 
[lkml]   [2019]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [GIT PULL 1/4] ARM: SoC platform updates
On Wed, May 15, 2019 at 11:43 PM Olof Johansson <olof@lixom.net> wrote:
>
> SoC updates, mostly refactorings and cleanups of old legacy platforms.
> Major themes this release:

Hmm. This brings in a new warning:

drivers/clocksource/timer-ixp4xx.c:78:20: warning:
‘ixp4xx_read_sched_clock’ defined but not used [-Wunused-function]

because that drivers is enabled for build testing, but that function
is only used under

#ifdef CONFIG_ARM
sched_clock_register(ixp4xx_read_sched_clock, 32, timer_freq);
#endif

It's not clear why that #ifdef is there. This driver only builds
non-ARM when COMPILE_TEST is enabled, and that #ifdef actually breaks
that build test.

I'm going to remove that #ifdef in my merge, because I do *not* want
to see new warnings, and it doesn't seem to make any sense.

Maybe that's the wrong resolution, please holler and let me know if
you want something else.

Linus

\
 
 \ /
  Last update: 2019-05-16 17:35    [W:0.047 / U:0.124 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site