lkml.org 
[lkml]   [2019]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] ASoC: cs42xx8: Add reset gpio handling
Date
Hi Mark

>
> On Mon, Apr 29, 2019 at 10:46:03AM +0000, S.j. Wang wrote:
>
> > + cs42xx8->gpio_reset = of_get_named_gpio(dev->of_node, "gpio-
> reset", 0);
> > + if (gpio_is_valid(cs42xx8->gpio_reset)) {
> > + ret = devm_gpio_request_one(dev, cs42xx8->gpio_reset,
> > + GPIOF_OUT_INIT_LOW, "cs42xx8 reset");
>
> You should just be able to request the GPIO by name without going
> through of_get_named_gpio() using devm_gpio_get().
>
Will send v2.

> > @@ -559,6 +577,7 @@ static int cs42xx8_runtime_resume(struct device
> > *dev)
> >
> > regcache_cache_only(cs42xx8->regmap, false);
> >
> > + regcache_mark_dirty(cs42xx8->regmap);
> > ret = regcache_sync(cs42xx8->regmap);
> > if (ret) {
> > dev_err(dev, "failed to sync regmap: %d\n", ret);
>
> This looks like an unrelated bugfix.

Will separate it to another patch.

Best regards
Wang shengjiu

\
 
 \ /
  Last update: 2019-05-16 07:50    [W:0.022 / U:1.616 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site