lkml.org 
[lkml]   [2019]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] arm64: vdso: Explicitly add build-id option
On Thu, May 16, 2019 at 4:51 AM Laura Abbott <labbott@redhat.com> wrote:
>
> Commit 691efbedc60d ("arm64: vdso: use $(LD) instead of $(CC) to
> link VDSO") switched to using LD explicitly. The --build-id option
> needs to be passed explicitly, similar to x86. Add this option.
>
> Fixes: 691efbedc60d ("arm64: vdso: use $(LD) instead of $(CC) to link VDSO")
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> arch/arm64/kernel/vdso/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/kernel/vdso/Makefile b/arch/arm64/kernel/vdso/Makefile
> index 744b9dbaba03..ca209103cd06 100644
> --- a/arch/arm64/kernel/vdso/Makefile
> +++ b/arch/arm64/kernel/vdso/Makefile
> @@ -13,6 +13,7 @@ targets := $(obj-vdso) vdso.so vdso.so.dbg
> obj-vdso := $(addprefix $(obj)/, $(obj-vdso))
>
> ldflags-y := -shared -nostdlib -soname=linux-vdso.so.1 \
> + $(call ld-option, --build-id) \
> $(call ld-option, --hash-style=sysv) -n -T
>
> # Disable gcov profiling for VDSO code


I missed that. Sorry.

You can add --build-id without $(call ld-option,...)
because it is supported by our minimal version of toolchain.

See commit log of 1e0221374e for example.


Otherwise, looks good to me.

Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>


--
Best Regards

Masahiro Yamada

\
 
 \ /
  Last update: 2019-05-16 07:00    [W:0.039 / U:16.484 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site