Messages in this thread | | | From | Doug Anderson <> | Date | Thu, 16 May 2019 15:44:51 -0700 | Subject | Re: [PATCH v2 2/2] drm/rockchip: dw_hdmi: Handle suspend/resume |
| |
Hi,
On Thu, May 16, 2019 at 2:40 PM Douglas Anderson <dianders@chromium.org> wrote: > > On Rockchip rk3288-based Chromebooks when you do a suspend/resume > cycle: > > 1. You lose the ability to detect an HDMI device being plugged in. > > 2. If you're using the i2c bus built in to dw_hdmi then it stops > working. > > Let's call the core dw-hdmi's suspend/resume functions to restore > things. > > NOTE: in downstream Chrome OS (based on kernel 3.14) we used the > "late/early" versions of suspend/resume because we found that the VOP > was sometimes resuming before dw_hdmi and then calling into us before > we were fully resumed. For now I have gone back to the normal > suspend/resume because I can't reproduce the problems. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > Changes in v2: > - Add forgotten static (Laurent) > - No empty stub for suspend (Laurent) > > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+)
Whoops, forgot that I should have carried forward:
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
-Doug
| |