[lkml]   [2019]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 4.14 057/115] net: dont keep lonely packets forever in the gro hash
    [ Upstream commit 605108acfe6233b72e2f803aa1cb59a2af3001ca ]

    Eric noted that with UDP GRO and NAPI timeout, we could keep a single
    UDP packet inside the GRO hash forever, if the related NAPI instance
    calls napi_gro_complete() at an higher frequency than the NAPI timeout.
    Willem noted that even TCP packets could be trapped there, till the
    next retransmission.
    This patch tries to address the issue, flushing the old packets -
    those with a NAPI_GRO_CB age before the current jiffy - before scheduling
    the NAPI timeout. The rationale is that such a timeout should be
    well below a jiffy and we are not flushing packets eligible for sane GRO.

    v1 -> v2:
    - clarified the commit message and comment

    RFC -> v1:
    - added 'Fixes tags', cleaned-up the wording.

    Reported-by: Eric Dumazet <>
    Fixes: 3b47d30396ba ("net: gro: add a per device gro flush timer")
    Signed-off-by: Paolo Abeni <>
    Acked-by: Willem de Bruijn <>
    Acked-by: Eric Dumazet <>
    Signed-off-by: David S. Miller <>
    Signed-off-by: Sasha Levin <>
    net/core/dev.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    diff --git a/net/core/dev.c b/net/core/dev.c
    index 93a1b07990b8d..90ec30d5b8514 100644
    --- a/net/core/dev.c
    +++ b/net/core/dev.c
    @@ -5308,11 +5308,14 @@ bool napi_complete_done(struct napi_struct *n, int work_done)
    if (work_done)
    timeout = n->dev->gro_flush_timeout;

    + /* When the NAPI instance uses a timeout and keeps postponing
    + * it, we need to bound somehow the time packets are kept in
    + * the GRO layer
    + */
    + napi_gro_flush(n, !!timeout);
    if (timeout)
    hrtimer_start(&n->timer, ns_to_ktime(timeout),
    - else
    - napi_gro_flush(n, false);
    if (unlikely(!list_empty(&n->poll_list))) {
    /* If n->poll_list is not empty, we need to mask irqs */

     \ /
      Last update: 2019-05-15 13:54    [W:4.124 / U:0.632 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site