[lkml]   [2019]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 4.19 084/113] rtlwifi: rtl8723ae: Fix missing break in switch statement
    From: Gustavo A. R. Silva <>

    commit 84242b82d81c54e009a2aaa74d3d9eff70babf56 upstream.

    Add missing break statement in order to prevent the code from falling
    through to case 0x1025, and erroneously setting rtlhal->oem_id to
    RT_CID_819X_ACER when rtlefuse->eeprom_svid is equal to 0x10EC and
    none of the cases in switch (rtlefuse->eeprom_smid) match.

    This bug was found thanks to the ongoing efforts to enable

    Fixes: 238ad2ddf34b ("rtlwifi: rtl8723ae: Clean up the hardware info routine")
    Signed-off-by: Gustavo A. R. Silva <>
    Signed-off-by: Kalle Valo <>
    Signed-off-by: Greg Kroah-Hartman <>

    drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c
    +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c
    @@ -1699,6 +1699,7 @@ static void _rtl8723e_read_adapter_info(
    rtlhal->oem_id = RT_CID_819X_LENOVO;
    + break;
    case 0x1025:
    rtlhal->oem_id = RT_CID_819X_ACER;

     \ /
      Last update: 2019-05-15 13:47    [W:4.237 / U:0.408 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site