lkml.org 
[lkml]   [2019]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 033/115] drm/sun4i: Set device driver data at bind time for use in unbind
    Date
    [ Upstream commit 02b92adbe33e6dbd15dc6e32540b22f47c4ff0a2 ]

    Our sun4i_drv_unbind gets the drm device using dev_get_drvdata.
    However, that driver data is never set in sun4i_drv_bind.

    Set it there to avoid getting a NULL pointer at unbind time.

    Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
    Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
    Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20190418132727.5128-3-paul.kocialkowski@bootlin.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/sun4i/sun4i_drv.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
    index 8d3c8070ed862..e09161cf312f7 100644
    --- a/drivers/gpu/drm/sun4i/sun4i_drv.c
    +++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
    @@ -96,6 +96,8 @@ static int sun4i_drv_bind(struct device *dev)
    ret = -ENOMEM;
    goto free_drm;
    }
    +
    + dev_set_drvdata(dev, drm);
    drm->dev_private = drv;
    INIT_LIST_HEAD(&drv->engine_list);
    INIT_LIST_HEAD(&drv->tcon_list);
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-05-15 13:17    [W:6.970 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site