lkml.org 
[lkml]   [2019]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support
From
Date


On 15/05/19 4:38 PM, Mark Brown wrote:
> On Wed, May 15, 2019 at 03:38:48PM +0530, Keerthy wrote:
>
>> @@ -172,6 +178,9 @@ static int lp87565_regulator_probe(struct platform_device *pdev)
>> if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87565_Q1) {
>> min_idx = LP87565_BUCK_10;
>> max_idx = LP87565_BUCK_23;
>> + } else if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87561_Q1) {
>> + min_idx = LP87565_BUCK_3210;
>> + max_idx = LP87565_BUCK_3210;
>
> This if/else chain should be a switch statement.

Okay. I will convert that in v2.

Thanks,
Keerthy

>

\
 
 \ /
  Last update: 2019-05-15 13:14    [W:0.052 / U:0.728 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site