lkml.org 
[lkml]   [2019]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 16/86] usb: gadget: net2272: Fix net2272_dequeue()
    Date
    [ Upstream commit 091dacc3cc10979ab0422f0a9f7fcc27eee97e69 ]

    Restore the status of ep->stopped in function net2272_dequeue().

    When the given request is not found in the endpoint queue
    the function returns -EINVAL without restoring the state of
    ep->stopped. Thus the endpoint keeps blocked and does not transfer
    any data anymore.

    This fix is only compile-tested, since we do not have a
    corresponding hardware. An analogous fix was tested in the sibling
    driver. See "usb: gadget: net2280: Fix net2280_dequeue()"

    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Guido Kiener <guido.kiener@rohde-schwarz.com>
    Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
    Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org>
    ---
    drivers/usb/gadget/udc/net2272.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c
    index 4b2444e75840..83d0544338ca 100644
    --- a/drivers/usb/gadget/udc/net2272.c
    +++ b/drivers/usb/gadget/udc/net2272.c
    @@ -962,6 +962,7 @@ net2272_dequeue(struct usb_ep *_ep, struct usb_request *_req)
    break;
    }
    if (&req->req != _req) {
    + ep->stopped = stopped;
    spin_unlock_irqrestore(&ep->dev->lock, flags);
    return -EINVAL;
    }
    --
    2.19.1


    \
     
     \ /
      Last update: 2019-05-15 12:59    [W:4.321 / U:1.556 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site