lkml.org 
[lkml]   [2019]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RESEND PATCH] nvdimm: fix some compilation warnings
Date
On Wed, 2019-05-15 at 16:25 -0700, Dan Williams wrote:
>
> > diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
> > index 4671776f5623..9f02a99cfac0 100644
> > --- a/drivers/nvdimm/btt.c
> > +++ b/drivers/nvdimm/btt.c
> > @@ -1269,11 +1269,9 @@ static int btt_read_pg(struct btt *btt, struct bio_integrity_payload *bip,
> >
> > ret = btt_data_read(arena, page, off, postmap, cur_len);
> > if (ret) {
> > - int rc;
> > -
> > /* Media error - set the e_flag */
> > - rc = btt_map_write(arena, premap, postmap, 0, 1,
> > - NVDIMM_IO_ATOMIC);
> > + btt_map_write(arena, premap, postmap, 0, 1,
> > + NVDIMM_IO_ATOMIC);
> > goto out_rtt;
>
> This doesn't look correct to me, shouldn't we at least be logging that
> the bad-block failed to be persistently tracked?

Yes logging it sounds good to me. Qian, can you include this in your
respin or shall I send a fix for it separately (since we were always
ignoring the failure here regardless of this patch)?


\
 
 \ /
  Last update: 2019-05-16 03:49    [W:0.032 / U:4.520 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site