Messages in this thread | | | Date | Wed, 15 May 2019 19:09:52 -0600 | From | Subash Abhinov Kasiviswanathan <> | Subject | Re: [PATCH 02/18] soc: qcom: create "include/soc/qcom/rmnet.h" |
| |
>>> +#ifndef _SOC_QCOM_RMNET_H_ >>> +#define _SOC_QCOM_RMNET_H_ >>> + >>> +#include <linux/types.h> >>> + >>> +/* Header structure that precedes packets in ETH_P_MAP protocol */ >>> +struct rmnet_map_header { >>> + u8 pad_len : 6; >>> + u8 reserved_bit : 1; >>> + u8 cd_bit : 1; >>> + u8 mux_id; >>> + __be16 pkt_len; >>> +} __aligned(1); >> >> If we move this into include/soc/, I want the structure to be >> portable, >> and avoid the bit fields. Please use mask/shift operations or the >> include/linux/bits.h macros instead to make this work with big-endian >> kernels. > > Sure, I'll do that. I did that everywhere else in the driver, > but here I just tried to preserve the original code as I moved > it. I will update at least these structures, and all existing > code (plus the IPA code) to use fields masks. > > -Alex >> >> Arnd >>
Hi Alex
Could we instead have the rmnet header definition in include/linux/if_rmnet.h
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |