[lkml]   [2019]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] dax: Arrange for dax_supported check to span multiple devices

> Pankaj reports that starting with commit ad428cdb525a "dax: Check the
> end of the block-device capacity with dax_direct_access()" device-mapper
> no longer allows dax operation. This results from the stricter checks in
> __bdev_dax_supported() that validate that the start and end of a
> block-device map to the same 'pagemap' instance.
> Teach the dax-core and device-mapper to validate the 'pagemap' on a
> per-target basis. This is accomplished by refactoring the
> bdev_dax_supported() internals into generic_fsdax_supported() which
> takes a sector range to validate. Consequently generic_fsdax_supported()
> is suitable to be used in a device-mapper ->iterate_devices() callback.
> A new ->dax_supported() operation is added to allow composite devices to
> split and route upper-level bdev_dax_supported() requests.
> Fixes: ad428cdb525a ("dax: Check the end of the block-device...")
> Cc: <>
> Cc: Jan Kara <>
> Cc: Ira Weiny <>
> Cc: Dave Jiang <>
> Cc: Mike Snitzer <>
> Cc: Keith Busch <>
> Cc: Matthew Wilcox <>
> Cc: Vishal Verma <>
> Cc: Heiko Carstens <>
> Cc: Martin Schwidefsky <>
> Reported-by: Pankaj Gupta <>
> Signed-off-by: Dan Williams <>

Thank you for the patch. Looks good to me.
I also tested the patch and it works well.

Reviewed-and-Tested-by: Pankaj Gupta <>

Best regards,

 \ /
  Last update: 2019-05-15 10:38    [W:0.045 / U:8.600 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site