lkml.org 
[lkml]   [2019]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3.18 78/86] bridge: Fix error path for kobject_init_and_add()
    On Wed, May 15, 2019 at 12:55:55PM +0200, Greg Kroah-Hartman wrote:
    > From: "Tobin C. Harding" <tobin@kernel.org>
    >
    > [ Upstream commit bdfad5aec1392b93495b77b864d58d7f101dc1c1 ]

    Greg you are not going to back port all of these kobject fixes are you?
    There is going to be a _lot_ of them. I'm not super comfortable
    generating all this work for you. And besides that, I keep making
    mistakes (reference to last nights find of double free in powerpc that
    you reviewed already), then we have to back port those too.

    For the record I've been going through all uses of kobject and splitting
    them into categories

    1. Broken
    2. Too complex to immediately tell
    3. Done correctly

    I'm not getting many in category #3, let's hope that some in #1 and #2 are
    my misunderstanding and that many in #2 should be in #3. I'm having fun
    fixing them but I shudder at making life hard for other people.

    Cheers,
    Tobin.

    \
     
     \ /
      Last update: 2019-05-15 22:50    [W:4.193 / U:1.272 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site