Messages in this thread | | | Date | Wed, 15 May 2019 17:14:26 +0200 | From | Greg KH <> | Subject | Re: [PATCH v2 1/1] bsr: do not use assignment in if condition |
| |
On Wed, May 15, 2019 at 08:39:52PM +0530, parna.naveenkumar@gmail.com wrote: > From: Naveen Kumar Parna <parna.naveenkumar@gmail.com> > > checkpatch.pl does not like assignment in if condition > > Signed-off-by: Naveen Kumar Parna <parna.naveenkumar@gmail.com> > --- > drivers/char/bsr.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)
If you do a v2, you always have to show below the --- line what changed from the previous version.
v3? :)
thanks,
greg k-h
| |