lkml.org 
[lkml]   [2019]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2 4/4] printk: make sure we always print console disabled message
On Fri 2019-04-26 14:44:45, Sergey Senozhatsky wrote:
>
> Forgot to mention that the series is still in RFC phase.
>
>
> On (04/26/19 14:33), Sergey Senozhatsky wrote:
> [..]
> > +++ b/kernel/printk/printk.c
> > @@ -2613,6 +2613,12 @@ static int __unregister_console(struct console *console)
> > pr_info("%sconsole [%s%d] disabled\n",
> > (console->flags & CON_BOOT) ? "boot" : "",
> > console->name, console->index);
> > + /*
> > + * Print 'console disabled' on all the consoles, including the
> > + * one we are about to unregister.
> > + */
> > + console_unlock();
> > + console_lock();
> >
> > res = _braille_unregister_console(console);
> > if (res)
>
> Need to think more if this is race free...

I am afraid that it is racy against for_each_console() when
removing the boot consoles.

I think that it is _not_ worth a code complication. It worked
this way for ages and people do not seem to complain.

Best Regards,
Petr

\
 
 \ /
  Last update: 2019-05-15 16:48    [W:0.036 / U:64.680 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site