lkml.org 
[lkml]   [2019]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V2 1/3] perf parse-regs: Split parse_regs
From
Date


On 5/15/2019 2:49 AM, Ravi Bangoria wrote:
>
> On 5/15/19 1:49 AM, kan.liang@linux.intel.com wrote:
>> From: Kan Liang <kan.liang@linux.intel.com>
>>
>> The available registers for --int-regs and --user-regs may be different,
>> e.g. XMM registers.
>>
>> Split parse_regs into two dedicated functions for --int-regs and
>> --user-regs respectively.
>>
>> Modify the warning message. "--user-regs=?" should be applied to show
>> the available registers for --user-regs.
>>
>> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
>> ---
>
> For patch 1 and 2,
> Tested-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
>
> Minor neat. Should we update document as well? May be something like:
>
> tools/perf/Documentation/perf-record.txt
>
> --user-regs::
> Similar to -I, but capture user registers at sample time. To list the available
> user registers use --user-regs=\?.
>
Hi Ravi,

Thanks for test.

The change of document looks good.

Thanks,
Kan

\
 
 \ /
  Last update: 2019-05-15 16:16    [W:0.063 / U:26.896 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site