Messages in this thread | | | Subject | Re: [PATCH v7 04/23] iommu: Introduce attach/detach_pasid_table API | From | Auger Eric <> | Date | Wed, 15 May 2019 15:06:58 +0200 |
| |
Hi Jean-Philippe,
On 5/15/19 2:09 PM, Jean-Philippe Brucker wrote: > On 08/04/2019 13:18, Eric Auger wrote: >> diff --git a/include/uapi/linux/iommu.h b/include/uapi/linux/iommu.h >> index edcc0dda7993..532a64075f23 100644 >> --- a/include/uapi/linux/iommu.h >> +++ b/include/uapi/linux/iommu.h >> @@ -112,4 +112,51 @@ struct iommu_fault { >> struct iommu_fault_page_request prm; >> }; >> }; >> + >> +/** >> + * SMMUv3 Stream Table Entry stage 1 related information >> + * The PASID table is referred to as the context descriptor (CD) table. >> + * >> + * @s1fmt: STE s1fmt (format of the CD table: single CD, linear table >> + or 2-level table) > > Running "scripts/kernel-doc -v -none" on this header produces some > warnings. Not sure if we want to get rid of all of them, but we should > at least fix the coding style for this comment (line must start with > " * "). I'm fixing it up on my sva/api branch Thanks!
Let me know if you want me to do the job for additional fixes.
Eric
> > Thanks, > Jean > >> + * @s1dss: STE s1dss (specifies the behavior when pasid_bits != 0 >> + and no pasid is passed along with the incoming transaction) >> + * Please refer to the smmu 3.x spec (ARM IHI 0070A) for full details >> + */ >> +struct iommu_pasid_smmuv3 { >> +#define PASID_TABLE_SMMUV3_CFG_VERSION_1 1 >> + __u32 version; >> + __u8 s1fmt; >> + __u8 s1dss; >> + __u8 padding[2]; >> +};
| |