lkml.org 
[lkml]   [2019]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 73/86] selftests/net: correct the return value for run_netsocktests
    Date
    [ Upstream commit 30c04d796b693e22405c38e9b78e9a364e4c77e6 ]

    The run_netsocktests will be marked as passed regardless the actual test
    result from the ./socket:

    selftests: net: run_netsocktests
    ========================================
    --------------------
    running socket test
    --------------------
    [FAIL]
    ok 1..6 selftests: net: run_netsocktests [PASS]

    This is because the test script itself has been successfully executed.
    Fix this by exit 1 when the test failed.

    Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/net/run_netsocktests | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/testing/selftests/net/run_netsocktests b/tools/testing/selftests/net/run_netsocktests
    index c09a682df56ae..19486dab2379e 100644
    --- a/tools/testing/selftests/net/run_netsocktests
    +++ b/tools/testing/selftests/net/run_netsocktests
    @@ -6,7 +6,7 @@ echo "--------------------"
    ./socket
    if [ $? -ne 0 ]; then
    echo "[FAIL]"
    + exit 1
    else
    echo "[PASS]"
    fi
    -
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-05-15 14:19    [W:4.023 / U:0.144 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site