lkml.org 
[lkml]   [2019]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 126/266] rtc: da9063: set uie_unsupported when relevant
    Date
    [ Upstream commit 882c5e552ffd06856de42261460f46e18319d259 ]

    The DA9063AD doesn't support alarms on any seconds and its granularity is
    the minute. Set uie_unsupported in that case.

    Reported-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
    Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
    Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
    Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/rtc/rtc-da9063.c | 7 +++++++
    1 file changed, 7 insertions(+)

    diff --git a/drivers/rtc/rtc-da9063.c b/drivers/rtc/rtc-da9063.c
    index d6c853bbfa9f..e93beecd5010 100644
    --- a/drivers/rtc/rtc-da9063.c
    +++ b/drivers/rtc/rtc-da9063.c
    @@ -491,6 +491,13 @@ static int da9063_rtc_probe(struct platform_device *pdev)
    da9063_data_to_tm(data, &rtc->alarm_time, rtc);
    rtc->rtc_sync = false;

    + /*
    + * TODO: some models have alarms on a minute boundary but still support
    + * real hardware interrupts. Add this once the core supports it.
    + */
    + if (config->rtc_data_start != RTC_SEC)
    + rtc->rtc_dev->uie_unsupported = 1;
    +
    irq_alarm = platform_get_irq_byname(pdev, "ALARM");
    ret = devm_request_threaded_irq(&pdev->dev, irq_alarm, NULL,
    da9063_alarm_event,
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-05-15 14:11    [W:4.129 / U:1.176 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site