Messages in this thread | | | Date | Tue, 14 May 2019 06:02:48 -0400 (EDT) | From | Pankaj Gupta <> | Subject | Re: [PATCH v8 2/6] virtio-pmem: Add virtio pmem driver |
| |
> >> > >> I think you should do the same here, vdev->priv is allocated in > >> virtio_pmem_probe. > >> > >> But maybe I am missing something important here :) > > > > Because virtio_balloon use "kzalloc" for allocation and needs to be freed. > > But virtio pmem uses "devm_kzalloc" which takes care of automatically > > deleting > > the device memory when associated device is detached. > > Hehe, thanks, that was the part that I was missing!
Thank you for the review.
Best regards, Pankaj > > -- > > Thanks, > > David / dhildenb >
| |