Messages in this thread | | | From | Stephen Boyd <> | Subject | Re: [PATCH] clk: sifive: restrict Kconfig scope for the FU540 PRCI driver | Date | Mon, 13 May 2019 13:22:20 -0700 |
| |
Quoting Paul Walmsley (2019-05-13 13:07:58) > Restrict Kconfig scope for SiFive clock and reset IP block drivers > such that they won't appear on most configurations that are unlikely > to support them. This is based on a suggestion from Pavel Machek > <pavel@ucw.cz>. Ideally this should be dependent on > CONFIG_ARCH_SIFIVE, but since that Kconfig directive does not yet > exist, add dependencies on RISCV or COMPILE_TEST for now. > > Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com> > Signed-off-by: Paul Walmsley <paul@pwsan.com> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: Pavel Machek <pavel@ucw.cz>
Reported-by?
> --- > drivers/clk/sifive/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/sifive/Kconfig b/drivers/clk/sifive/Kconfig > index 8db4a3eb4782..27a8fe531357 100644 > --- a/drivers/clk/sifive/Kconfig > +++ b/drivers/clk/sifive/Kconfig > @@ -2,6 +2,7 @@ > > menuconfig CLK_SIFIVE > bool "SiFive SoC driver support" > + depends on RISCV || COMPILE_TEST > help > SoC drivers for SiFive Linux-capable SoCs. > > @@ -10,6 +11,7 @@ if CLK_SIFIVE > config CLK_SIFIVE_FU540_PRCI > bool "PRCI driver for SiFive FU540 SoCs" > select CLK_ANALOGBITS_WRPLL_CLN28HPC > + depends on RISCV || COMPILE_TEST
This isn't needed? The config already implicitly depends on CLK_SIFIVE which depends on RISCV || COMPILE_TEST. This line should be removed.
| |