Messages in this thread | | | Date | Mon, 13 May 2019 17:47:38 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 4/4] Revert "platform/chrome: cros_ec_spi: Transfer messages at high priority" |
| |
On Mon, May 13, 2019 at 09:03:28AM -0700, Doug Anderson wrote: > On Mon, May 13, 2019 at 9:02 AM Mark Brown <broonie@kernel.org> wrote:
> > I'm not saying the other changes aren't helping, I'm saying that it's > > not clear that this revert is improving things.
> If I add a call to force the pumping to happen on the SPI thread then > the commit I'm reverting here is useless though, isn't it?
Well, I'm not convinced that that change is ideal anyway and it does leave you vulnerable to further changes in the SPI core pushing things out to calling context which feels like it isn't going to be helping robustness. [unhandled content-type:application/pgp-signature] | |