Messages in this thread | | | From | Chaitanya Kulkarni <> | Subject | Re: [PATCH v3 1/7] devcoredump: use memory_read_from_buffer | Date | Mon, 13 May 2019 15:28:28 +0000 |
| |
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>.
On 05/12/2019 08:55 AM, Akinobu Mita wrote: > Use memory_read_from_buffer() to simplify devcd_readv(). > > Cc: Johannes Berg <johannes@sipsolutions.net> > Cc: Keith Busch <keith.busch@intel.com> > Cc: Jens Axboe <axboe@fb.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Sagi Grimberg <sagi@grimberg.me> > Cc: Minwoo Im <minwoo.im.dev@gmail.com> > Cc: Kenneth Heitke <kenneth.heitke@intel.com> > Reviewed-by: Johannes Berg <johannes@sipsolutions.net> > Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> > --- > * v3 > - No change since v2 > > drivers/base/devcoredump.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/drivers/base/devcoredump.c b/drivers/base/devcoredump.c > index f1a3353..3c960a6 100644 > --- a/drivers/base/devcoredump.c > +++ b/drivers/base/devcoredump.c > @@ -164,16 +164,7 @@ static struct class devcd_class = { > static ssize_t devcd_readv(char *buffer, loff_t offset, size_t count, > void *data, size_t datalen) > { > - if (offset > datalen) > - return -EINVAL; > - > - if (offset + count > datalen) > - count = datalen - offset; > - > - if (count) > - memcpy(buffer, ((u8 *)data) + offset, count); > - > - return count; > + return memory_read_from_buffer(buffer, count, &offset, data, datalen); > } > > static void devcd_freev(void *data) >
| |