lkml.org 
[lkml]   [2019]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 5/8] Staging: kpc2000: kpc_dma: Resolve checkpath errors Macros in paranthesis & trailing statements on next line.
    Date
    This patch fixes below errors reported by checkpath
    ERROR: Macros with complex values should be enclosed in parentheses
    CHECK: Prefer using the BIT macro
    ERROR: trailing statements should be on next line
    ERROR: trailing statements should be on next line

    Signed-off-by: Vandana BN <bnvandana@gmail.com>
    ---
    v2 - split changes to multiple patches
    v3 - edit commit message, subject line
    v4 - edit commit message

    drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 8 +++++---
    1 file changed, 5 insertions(+), 3 deletions(-)

    diff --git a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c b/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c
    index 0b8dcf046136..e996ced77bd6 100644
    --- a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c
    +++ b/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c
    @@ -14,7 +14,7 @@ MODULE_LICENSE("GPL");
    MODULE_AUTHOR("Matt.Sickler@daktronics.com");

    #define KPC_DMA_CHAR_MAJOR UNNAMED_MAJOR
    -#define KPC_DMA_NUM_MINORS 1 << MINORBITS
    +#define KPC_DMA_NUM_MINORS BIT(MINORBITS)
    static DEFINE_MUTEX(kpc_dma_mtx);
    static int assigned_major_num;
    static LIST_HEAD(kpc_dma_list);
    @@ -55,9 +55,11 @@ static ssize_t show_engine_regs(struct device *dev, struct device_attribute *at
    {
    struct kpc_dma_device *ldev;
    struct platform_device *pldev = to_platform_device(dev);
    - if (!pldev) return 0;
    + if (!pldev)
    + return 0;
    ldev = platform_get_drvdata(pldev);
    - if (!ldev) return 0;
    + if (!ldev)
    + return 0;

    return scnprintf(buf, PAGE_SIZE,
    "EngineControlStatus = 0x%08x\n"
    --
    2.17.1
    \
     
     \ /
      Last update: 2019-05-13 15:44    [W:4.073 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site