Messages in this thread | | | Date | Mon, 13 May 2019 12:40:31 +0200 | From | Pablo Neira Ayuso <> | Subject | Re: [PATCH net] netfilter: nf_queue:fix reinject verdict handling |
| |
On Mon, May 13, 2019 at 10:36:51AM +0000, Jagdish Motwani wrote: > Hi Pablo, > > The case I am referring to is : If there are more than 1 hooks > returning NF_QUEUE verdict. When the first queue reinjects the > packet, 'nf_reinject' starts traversing hooks with hook_index (i). > However if it again receives a NF_QUEUE verdict (by some other > netfilter hook), it queue with the wrong hook_index. So, when the > second queue reinjects the packet, it re-executes some hooks in > between the first 2 hooks.
Please, include this description in the patch. And thanks for explaining.
> Thanks, I will mark : Fixes: 960632ece694 ("netfilter: convert hook list to an array") and update the description also.
Thanks, will wait for v2.
| |