lkml.org 
[lkml]   [2019]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] irqchip: ingenic: Drop dependency on MACH_INGENIC, use COMPILE_TEST
My bad, I'm stupid. I tested CONFIG_COMPILE_TEST on MIPS...

The driver does depend on arch-specific includes so COMPILE_TEST
cannot be used; I'll send a V2.

-Paul


Le sam. 11 mai 2019 à 19:09, Paul Cercueil <paul@crapouillou.net> a
écrit :
> Depending on MACH_INGENIC prevent us from creating a generic kernel
> that
> works on more than one MIPS board. Instead, we just depend on MIPS
> being
> set.
>
> On other architectures, this driver can still be built, thanks to
> COMPILE_TEST. This is used by automated tools to find bugs, for
> instance.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/irqchip/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 5438abb1baba..864dc38782e8 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -286,9 +286,9 @@ config MIPS_GIC
> select MIPS_CM
>
> config INGENIC_IRQ
> - bool
> - depends on MACH_INGENIC
> - default y
> + bool "Ingenic JZ47xx IRQ controller driver"
> + depends on MIPS || COMPILE_TEST
> + default MACH_INGENIC
>
> config RENESAS_H8300H_INTC
> bool
> --
> 2.21.0.593.g511ec345e18
>


\
 
 \ /
  Last update: 2019-05-11 20:44    [W:0.166 / U:1.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site