Messages in this thread | | | Date | Sat, 11 May 2019 17:25:19 +0200 | From | Andrew Lunn <> | Subject | Re: net: phy: realtek: regression, kernel null pointer dereference |
| |
> Hi Andrew, > it is configured as in the vanilla kernel: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi#n191 > ,that is, > phy-mode = "rgmii"; > There are also these configuration items: > tx_delay = <0x28>; > rx_delay = <0x11>; > > Instead of going the trial-and-error way, please, can you suggest a > probably good configuration?
I just found the same.
Interestingly, the device tree binding says:
Optional properties: - tx_delay: Delay value for TXD timing. Range value is 0~0x7F, 0x30 as default. - rx_delay: Delay value for RXD timing. Range value is 0~0x7F, 0x10 as default.
So it is not using quite the default values. But there is no documentation about what these values mean. Given the difference of 0x20, it could be this is adding the needed TX delay, but not the RX delay?
So you could try:
rgmii-rxid
And it is not clear what RX and TX mean, so also try
rgmii-txid.
in case they are swapped.
Andrew
| |