lkml.org 
[lkml]   [2019]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] bfq: backport: update internal depth state when queue depth changes
On Fri, May 10, 2019 at 10:56:32AM -0700, Eric Wheeler wrote:
>From: Jens Axboe <axboe@kernel.dk>
>
>commit 77f1e0a52d26242b6c2dba019f6ebebfb9ff701e upstream
>
>A previous commit moved the shallow depth and BFQ depth map calculations
>to be done at init time, moving it outside of the hotter IO path. This
>potentially causes hangs if the users changes the depth of the scheduler
>map, by writing to the 'nr_requests' sysfs file for that device.
>
>Add a blk-mq-sched hook that allows blk-mq to inform the scheduler if
>the depth changes, so that the scheduler can update its internal state.
>
>Signed-off-by: Eric Wheeler <bfq@linux.ewheeler.net>
>Tested-by: Kai Krakow <kai@kaishome.de>
>Reported-by: Paolo Valente <paolo.valente@linaro.org>
>Fixes: f0635b8a416e ("bfq: calculate shallow depths at init time")
>Signed-off-by: Jens Axboe <axboe@kernel.dk>
>Cc: stable@vger.kernel.org

I wasn't clear on what was backported here, so I've queued the upstream
version on 4.19 and 4.14, it doesn't seem to be relevant to older
branches.

--
Thanks,
Sasha

\
 
 \ /
  Last update: 2019-05-10 22:19    [W:1.581 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site