Messages in this thread | | | Date | Fri, 10 May 2019 16:18:05 +0200 | From | Miquel Raynal <> | Subject | Re: [PATCH v1] mtd: rawnand: Add Macronix NAND read retry support |
| |
Hello,
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote on Fri, 10 May 2019 15:37:04 +0200:
> Hello, > > Some purely cosmetic suggestions below. > > On Fri, 10 May 2019 15:41:02 +0800 > Mason Yang <masonccyang@mxic.com.tw> wrote: > > > + if (ret) > > + pr_err("set feature failed to read retry moded:%d\n", mode); > > I don't know what is the policy in the MTD/NAND subsystem, but > shouldn't you be using dev_err() instead of pr_err() here to have a > nice prefix for the message ? > > dev_err(&nand_to_mtd(chip)->dev, "set feature ..", mode);
Actually, no, manufacturer initializations happens in nand_scan_tail() which runs before mtd_device_register(). At this point, mtd->dev is not yet populated so dev_err() cannot be used. You should keep a pr_err().
Thanks, Miquèl
| |