Messages in this thread | | | Date | Fri, 10 May 2019 10:14:40 +0100 | From | Qais Yousef <> | Subject | Re: [PATCH 4/7] sched: Add sched_load_rq tracepoint |
| |
On 05/10/19 10:51, Dietmar Eggemann wrote: > Hi Qais, > > On 5/5/19 1:57 PM, Qais Yousef wrote: > > [...] > > > diff --git a/kernel/sched/sched_tracepoints.h b/kernel/sched/sched_tracepoints.h > > new file mode 100644 > > index 000000000000..f4ded705118e > > --- /dev/null > > +++ b/kernel/sched/sched_tracepoints.h > > @@ -0,0 +1,39 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Scheduler tracepoints that are probe-able only and aren't exported ABI in > > + * tracefs. > > + */ > > + > > +#include <trace/events/sched.h> > > + > > +#define SCHED_TP_PATH_LEN 64 > > + > > + > > +static __always_inline void sched_tp_load_cfs_rq(struct cfs_rq *cfs_rq) > > +{ > > + if (trace_sched_load_rq_enabled()) { > > + int cpu = cpu_of(rq_of(cfs_rq)); > > + char path[SCHED_TP_PATH_LEN]; > > + > > + cfs_rq_tg_path(cfs_rq, path, SCHED_TP_PATH_LEN); > > + trace_sched_load_rq(cpu, path, &cfs_rq->avg); > > This will let a !CONFIG_SMP build fail.
You're right. sched_avg is only defined if CONFIG_SMP. Fixed all three functions.
Thanks!
-- Qais Yousef
| |