Messages in this thread | | | From | Kees Cook <> | Date | Wed, 1 May 2019 11:25:23 -0700 | Subject | Re: fix filler_t callback type mismatches |
| |
On Wed, May 1, 2019 at 9:07 AM Christoph Hellwig <hch@lst.de> wrote: > > Casting mapping->a_ops->readpage to filler_t causes an indirect call > type mismatch with Control-Flow Integrity checking. This change fixes > the mismatch in read_cache_page_gfp and read_mapping_page by adding > using a NULL filler argument as an indication to call ->readpage > directly, and by passing the right parameter callbacks in nfs and jffs2.
Nice. This looks great; thanks for looking at this. For the series (including patch 5):
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |