Messages in this thread | | | Date | Wed, 1 May 2019 15:08:25 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH][next] kobject: fix dereference before null check on kobj |
| |
On Wed, May 01, 2019 at 01:43:17PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The kobj pointer is being null-checked so potentially it could be null, > however, the ktype declaration before the null check is dereferencing kobj > hence we have a potential null pointer deference. Fix this by moving the > assignment of ktype after kobj has been null checked. > > Addresses-Coverity: ("Dereference before null check") > Fixes: aa30f47cf666 ("kobject: Add support for default attribute groups to kobj_type") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > lib/kobject.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)
Nice catch, thanks, will go queue this up now.
greg k-h
| |