Messages in this thread | | | From | Eric Anholt <> | Subject | Re: [PATCH v3 3/3] drm/panfrost: Add initial panfrost driver | Date | Tue, 09 Apr 2019 14:27:49 -0700 |
| |
Eric Anholt <eric@anholt.net> writes:
> [ Unknown signature status ] > Rob Herring <robh@kernel.org> writes: > >> This adds the initial driver for panfrost which supports Arm Mali >> Midgard and Bifrost family of GPUs. Currently, only the T860 and >> T760 Midgard GPUs have been tested. > >> +static int panfrost_ioctl_get_bo_offset(struct drm_device *dev, void *data, >> + struct drm_file *file_priv) >> +{ >> + struct drm_panfrost_get_bo_offset *args = data; >> + struct drm_gem_object *gem_obj; >> + struct panfrost_gem_object *bo; >> + > > Missing check for pad == 0. With that fixed, > > Reviewed-by: Eric Anholt <eric@anholt.net>
I suppose you could also drop both flags and pad from uapi, since both of them must be 0 filled and you could just add a new flags at the end of the create struct if you ever need one. [unhandled content-type:application/pgp-signature] | |