lkml.org 
[lkml]   [2019]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH RFC] staging: wilc1000: give usleep_range a range
Date
Hi Nicholas

On 4/6/19 5:01 AM, Nicholas Mc Guire wrote:
> External E-Mail
>
>
> Someone that knows the motivation for setting the time to 2 millisecond
> might need to check if the 2 milliseconds where seen as tollerable max or
> min - I'm assuming it was the min so extending.

2 msec is the time the chip takes to wake up from sleep.

Increasing the maximum to 5 msec will impact the throughput since this call is on the transmit path.

> diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c
> index c238969..42da533 100644
> --- a/drivers/staging/wilc1000/wilc_wlan.c
> +++ b/drivers/staging/wilc1000/wilc_wlan.c
> @@ -408,7 +408,7 @@ void chip_wakeup(struct wilc *wilc)
> wilc->hif_func->hif_write_reg(wilc, 1, reg & ~BIT(1));
>
> do {
> - usleep_range(2 * 1000, 2 * 1000);
> + usleep_range(2 * 1000, 5 * 1000);
> wilc_get_chipid(wilc, true);
> } while (wilc_get_chipid(wilc, true) == 0);
> } while (wilc_get_chipid(wilc, true) == 0);
> @@ -423,7 +423,7 @@ void chip_wakeup(struct wilc *wilc)
> &clk_status_reg);
>
> while ((clk_status_reg & 0x1) == 0) {
> - usleep_range(2 * 1000, 2 * 1000);
> + usleep_range(2 * 1000, 5 * 1000);
>
> wilc->hif_func->hif_read_reg(wilc, 0xf1,
> &clk_status_reg);


Thanks,

Adham

\
 
 \ /
  Last update: 2019-04-08 23:11    [W:1.176 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site