lkml.org 
[lkml]   [2019]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4] dt-bindings: gpu: add bindings for the ARM Mali Bifrost GPU
On Sun, Apr 7, 2019 at 5:17 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Hi Rob,
>
> Le 01/04/2019 13:24, Neil Armstrong a écrit :
> > On 01/04/2019 12:00, Steven Price wrote:
> >> On 01/04/2019 09:09, Neil Armstrong wrote:
> >>> Add the bindings for the Bifrost family of ARM Mali GPUs.
> >>>
> >>> The Bifrost GPU architecture is similar to the Midgard family,
> >>> but with a different Shader Core & Execution Engine structures.
> >>>
> >>> Bindings are based on the Midgard family bindings, but the inner
> >>> architectural changes makes it a separate family needing separate
> >>> bindings.
> >>>
> >>> The Bifrost GPUs are present in a number of recent SoCs, like the
> >>> Amlogic G12A Family, and many other vendors.
> >>> The Amlogic vendor specific compatible is added to handle the
> >>> specific IP integration differences and dependencies.
> >>>
> >>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> >>> ---
> >>> .../bindings/gpu/arm,mali-bifrost.txt | 92 +++++++++++++++++++
> >>> 1 file changed, 92 insertions(+)
> >>> create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
> >>>
> >>> Changes since v3:
> >>> - Added note about discoverable model/revision
> >>> - Enforced fixed defined irq order
> >>> - Fixed typo in accommodate
> >>>
> >>> Changes since v2:
> >>> - moved to a single compatible since HW is fully discoverable
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
> >>> new file mode 100644
> >>> index 000000000000..711c9ead17a2
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
> >>> @@ -0,0 +1,92 @@
> >>> +ARM Mali Bifrost GPU
> >>> +====================
> >>> +
> >>> +Required properties:
> >>> +
> >>> +- compatible :
> >>> + * Since Mali Bifrost GPU model/revision if fully discoverable by reading
> >> ^^
> >> s/if/is/
>
> Should I still send a v5 to fixing this typo ? I can fix it while applying it.

No need to resend. I planned to apply it, but if you are going to:

Reviewed-by: Rob Herring <robh@kernel.org>

\
 
 \ /
  Last update: 2019-04-08 21:07    [W:0.079 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site