Messages in this thread | | | Subject | Re: [PATCH] tools/power turbostat: fix file descriptor leaks | From | Prarit Bhargava <> | Date | Mon, 8 Apr 2019 13:04:52 -0400 |
| |
On 4/8/19 12:12 PM, Gustavo A. R. Silva wrote: > Fix file descriptor leaks by closing fp before return. > > Addresses-Coverity-ID: 1444591 ("Resource leak") > Addresses-Coverity-ID: 1444592 ("Resource leak") > Fixes: 5ea7647b333f ("tools/power turbostat: Warn on bad ACPI LPIT data") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Prarit Bhargava <prarit@redhat.com>
P.
> --- > tools/power/x86/turbostat/turbostat.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c > index c7727be9719f..78d9acba8e9b 100644 > --- a/tools/power/x86/turbostat/turbostat.c > +++ b/tools/power/x86/turbostat/turbostat.c > @@ -2924,6 +2924,7 @@ int snapshot_cpu_lpi_us(void) > if (retval != 1) { > fprintf(stderr, "Disabling Low Power Idle CPU output\n"); > BIC_NOT_PRESENT(BIC_CPU_LPI); > + fclose(fp); > return -1; > } > > @@ -2950,6 +2951,7 @@ int snapshot_sys_lpi_us(void) > if (retval != 1) { > fprintf(stderr, "Disabling Low Power Idle System output\n"); > BIC_NOT_PRESENT(BIC_SYS_LPI); > + fclose(fp); > return -1; > } > fclose(fp); >
| |