Messages in this thread | | | Date | Mon, 8 Apr 2019 17:10:10 +0200 | From | Borislav Petkov <> | Subject | Re: [RFC PATCH v3 4/4] x86: Add hypercall for acrn_guest |
| |
On Mon, Apr 08, 2019 at 04:12:11PM +0800, Zhao Yakui wrote: > When acrn_hypervisor is detected, the hypercall is needed so that the > acrn guest can query/config some settings. For example: it can be used > to query the resources in hypervisor and manage the CPU/memory/device/ > interrupt for Guest system.
Good example.
What is "Guest system" and why is capitalized? Do you mean "the guest operating system" or simply "the guest"?
> So the hypercall is added so that the kernel can communicate with the
"So add the hypercall so that... "
> low-level acrn-hypervisor.
Is it acrn_hypervisor or acrn-hypervisor or the ACRN hypervisor or ...?
Unify the naming pls.
> On x86 it is implemented by using vmacll when
During last review Thomas said:
"is implemented with the VMCALL instruction"
You still have it wrong. Which makes me think you haven't even gone over *all* review comments as this is the second missed review comment in a 4-patches set.
So I'm going to stop reviewing here and won't look at your patches until you incorporate *all* review comments from all people.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |