Messages in this thread | | | From | Linus Walleij <> | Date | Mon, 8 Apr 2019 14:05:10 +0200 | Subject | Re: [PATCH 1/3] ARM: dts: stm32: add stpmic1 support on stm32mp157c ed1 board |
| |
On Wed, Apr 3, 2019 at 3:41 PM Pascal PAILLET-LME <p.paillet@st.com> wrote:
> This patch adds stpmic1 support on stm32mp157c ed1 board. > The STPMIC1 is a PMIC from STMicroelectronics. The STPMIC1 integrates 10 > regulators, 3 power switches, a watchdog and an input for a power on key. > > Signed-off-by: Pascal Paillet <p.paillet@st.com>
OK
> + /delete-property/dmas; > + /delete-property/dma-names;
Maybe you can add a comment both to the commit message and the DTS file as to why you are doing this?
I hope you are not trying to work around a bug in the driver by stripping out DMA configuration from the device tree, because then it is probably a better idea to fix the bug.
Yours, Linus Walleij
| |