Messages in this thread | | | Subject | Re: [PATCH v4 0/6] normalize IOMMU dma mode boot options | From | "Leizhen (ThunderTown)" <> | Date | Mon, 8 Apr 2019 17:51:56 +0800 |
| |
On 2019/4/8 14:32, Thomas Gleixner wrote: > On Mon, 8 Apr 2019, Leizhen (ThunderTown) wrote: >>> >>> This will break systems using boot options as now, and I think >>> this is unacceptable. If you want to do so, just introduce iommu.dma_mode >>> on top of those iommu boot options with dma mode boot options unchanged, >>> and iommu.dma_mode is for all archs but compatible with them. >> >> I just changed the boot options name, but keep the function no change. I added >> all related maintainers/supporters in the "to=" list, maybe we can disuss this. > > Changing the name _IS_ the problem. Think about unattended updates. > >> Should I add some "obsoleted" warnings for old options and keep them for a while? > > No, just keep the old options around for backwards compatibilty sake. We > just do not add new arch specific options in the future. New options need > to use the generic iommu.dma_mode name space.
OK, thanks for your advise.
> > Thanks, > > tglx > > . >
-- Thanks! BestRegards
| |