Messages in this thread | | | From | Aisheng Dong <> | Subject | RE: [PATCH V6 4/4] rtc: imx-sc: add rtc alarm support | Date | Tue, 9 Apr 2019 03:35:59 +0000 |
| |
[...]
> > > +static int imx_sc_rtc_alarm_irq_enable(struct device *dev, unsigned > > > +int > > > +enable) { > > > + imx_scu_irq_enable(SC_IRQ_GROUP_RTC, SC_IRQ_RTC, enable); > > > + > > > + return 0; > > > +} > > > + > > > +static int imx_sc_rtc_read_alarm(struct device *dev, struct > > > +rtc_wkalrm > > > +*alrm) { > > > > I still think here needs a doc explain why needs this and why it's > > safe to do that. > > I will add a comment here, for the doc, it should be another topic of RTC > framework, we can do it later.
I'm fine with it. BTW, don't miss the next minor comments when you resend.
Regards Dong Aisheng
> > > + .set_alarm = imx_sc_rtc_set_alarm, > > > + .alarm_irq_enable = imx_sc_rtc_alarm_irq_enable, }; > > > + > > > +static int imx_sc_rtc_alarm_sc_notify(struct notifier_block *nb, > > > + unsigned long event, void *group) > > > > Not necessary to have such a long function name. > > Imx_sc_rtc_alarm_notify() should be ok > >
| |